Create cuda utils module #676
Conversation
…I/pennylane-lightning into clean_LGPU_utils_test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 97.10% 99.06% +1.96%
==========================================
Files 150 207 +57
Lines 19410 29454 +10044
==========================================
+ Hits 18848 29180 +10332
+ Misses 562 274 -288 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
added
ci:use-multi-gpu-runner
multiphaseCFD
changed the title
There was a problem hiding this comment.
Thanks @multiphaseCFD! Just a few minor suggestions, but it should be good to merge at any time.
pennylane_lightning/core/src/simulators/lightning_gpu/algorithms/CMakeLists.txt
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/CMakeLists.txt
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/utils/cuda_utils/tests/CMakeLists.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice review by @maliasadi , I don't have much to add here. LGTM, but maybe we can simplify a bit by including CUDA utils conditionally in the generic utils.
pennylane_lightning/core/src/simulators/lightning_gpu/algorithms/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Thanks @vincentmr ! Agree and just update the PR by linking |
Co-authored-by: Ali Asadi <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Create CUDA_Utils module
Description of the Change:
All the common components (in
lightning_gpu/utils/) that can be shared with othercuda-basedbackend are move to/src/utils/cuda_utils/.Note that the
lightning_gpu_utilis still kept to not break the cmake script.lightning_gpu_utilsis only required for C++ layer unit tests oflightning_gpuafter applying changes in this PR.Benefits:
Possible Drawbacks:
Related GitHub Issues: